From 97d23b39980c6291f91e41920aac28da2b162e42 Mon Sep 17 00:00:00 2001
From: Ondrej Vlach <ondrej@vlach.xyz>
Date: Wed, 7 Aug 2024 14:18:55 +0200
Subject: [PATCH] refactor(controllers): extract validation of created data
 into separate method

---
 .../Controllers/Api/V1/TaskEstimation.php     | 38 ++++++++++++-------
 1 file changed, 24 insertions(+), 14 deletions(-)

diff --git a/app/Http/Controllers/Api/V1/TaskEstimation.php b/app/Http/Controllers/Api/V1/TaskEstimation.php
index b445e25..1750c43 100644
--- a/app/Http/Controllers/Api/V1/TaskEstimation.php
+++ b/app/Http/Controllers/Api/V1/TaskEstimation.php
@@ -99,20 +99,8 @@ public function estimate(string $countryCode, string $startDate, int $minutesDur
             return response()->json(['errors' => ['startDate' => ['validation.date_ymdhi']]], 400);
         }
 
-        if ($startWorkday->isAfter($endWorkday)) {
-            return response()->json(['errors' => ['startWorkday' => ['validation.start_workday_must_be_before_end_workday']]], 400);
-        }
-
-        if ($startWorkday->isEqualTo($endWorkday)) {
-            return response()->json(['errors' => ['startWorkday' => ['validation.start_workday_must_not_be_equal_to_end_workday']]], 400);
-        }
-
-        if ($startWorkday->isAfter(LocalTime::fromNativeDateTime($startDate))) {
-            return response()->json(['errors' => ['startDate' => ['validation.start_workday_must_be_before_start_date']]], 400);
-        }
-
-        if ($endWorkday->isBefore(LocalTime::fromNativeDateTime($startDate))) {
-            return response()->json(['errors' => ['endWorkday' => ['validation.end_workday_must_be_after_start_date']]], 400);
+        if (($result = $this->validateParsedData($startDate, $startWorkday, $endWorkday)) !== null) {
+            return $result;
         }
 
         $workMinutes = $this->durationConvertor->convertIntoWorkDuration($duration, $startWorkday, $endWorkday, $startDate);
@@ -133,4 +121,26 @@ public function estimate(string $countryCode, string $startDate, int $minutesDur
             'estimation_date' => $dueDate->format('Y-m-d H:i:s'),
         ]);
     }
+
+
+    private function validateParsedData(\DateTimeInterface $startDate, LocalTime $startWorkday, LocalTime $endWorkday): JsonResponse|null
+    {
+        if ($startWorkday->isAfter($endWorkday)) {
+            return response()->json(['errors' => ['startWorkday' => ['validation.start_workday_must_be_before_end_workday']]], 400);
+        }
+
+        if ($startWorkday->isEqualTo($endWorkday)) {
+            return response()->json(['errors' => ['startWorkday' => ['validation.start_workday_must_not_be_equal_to_end_workday']]], 400);
+        }
+
+        if ($startWorkday->isAfter(LocalTime::fromNativeDateTime($startDate))) {
+            return response()->json(['errors' => ['startDate' => ['validation.start_workday_must_be_before_start_date']]], 400);
+        }
+
+        if ($endWorkday->isBefore(LocalTime::fromNativeDateTime($startDate))) {
+            return response()->json(['errors' => ['endWorkday' => ['validation.end_workday_must_be_after_start_date']]], 400);
+        }
+
+        return null;
+    }
 }