From 5115265592db1ea4392ce4729d2fae94af051622 Mon Sep 17 00:00:00 2001
From: Ondrej Vlach <ondrej@vlach.xyz>
Date: Tue, 28 Nov 2023 18:48:58 +0100
Subject: [PATCH] some observability

---
 src/chromium/rocket.rs | 7 +++++--
 src/main.rs            | 8 +++++++-
 src/routes/pdf.rs      | 4 ++--
 3 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/src/chromium/rocket.rs b/src/chromium/rocket.rs
index 3fd1dc1..4239add 100644
--- a/src/chromium/rocket.rs
+++ b/src/chromium/rocket.rs
@@ -2,7 +2,7 @@ use std::{sync::Arc, time::Duration};
 use async_trait::async_trait;
 use async_mutex::Mutex;
 use headless_chrome::{Browser, LaunchOptions};
-use tracing::{error, info, debug, trace, warn, trace_span};
+use tracing::{error, info, debug, trace, warn, trace_span, info_span};
 use rocket::{fairing::{Fairing, self}, Rocket, Build, Request, request::{FromRequest, Outcome}, futures::pin_mut, http::Status};
 use tokio::time::sleep;
 
@@ -107,11 +107,14 @@ impl ChromiumCoordinator {
     }
 
     pub async fn get_browser(&self) -> std::result::Result<BrowserHolder, ()> {
+        let span = info_span!("get_browser");
+        let _enter = span.enter();
         loop {
+            info!("trying to get a browser instance");
             match self.try_get_browser().await {
                 Ok(browser) => return Ok(browser),
                 Err(_) => {
-                    trace!("all instances of browser are dead... waiting for    ");
+                    warn!("all instances of browser are dead... waiting for new instance");
                     // all instances may be dead ... we must wait for new instance
                 }
             }
diff --git a/src/main.rs b/src/main.rs
index aa5eb88..8a5c08b 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -1,7 +1,13 @@
+use nanobyte_opentelemetry::{default_filter_layer, LogLevel};
 use ovlach_pdf::rocket_builder;
+use tracing::Level;
 
 #[rocket::main]
 async fn main() {
-    let _opentelemetry = nanobyte_opentelemetry::init_telemetry(env!("CARGO_PKG_NAME"), env!("CARGO_PKG_VERSION"));
+    let _opentelemetry = nanobyte_opentelemetry::init_telemetry(
+        env!("CARGO_PKG_NAME"),
+        env!("CARGO_PKG_VERSION"), 
+        Some(default_filter_layer(LogLevel::Normal))
+    );
     let _ = rocket_builder().launch().await;
 }
\ No newline at end of file
diff --git a/src/routes/pdf.rs b/src/routes/pdf.rs
index 08ce2cf..edeb080 100644
--- a/src/routes/pdf.rs
+++ b/src/routes/pdf.rs
@@ -42,7 +42,7 @@ fn generate_pdf(browser: Browser) {
 }
 
 #[get("/cv/<username>/pdf")]
-pub async fn render_pdf_cv(username: &str, browser: BrowserHolder, tracing: TracingSpan) -> NamedFile { 
+pub async fn render_pdf_cv(username: &str, browser: BrowserHolder, tracing: TracingSpan) -> Option<NamedFile> { 
     let entered_span = tracing.0.enter();
     let span = info_span!("render_pdf", username = username);
     info!("generate PDF");
@@ -51,5 +51,5 @@ pub async fn render_pdf_cv(username: &str, browser: BrowserHolder, tracing: Trac
     });
     info!("done generating");
     drop(entered_span);
-    NamedFile::open("/tmp/foo.pdf").await.expect("failed to open foo.pdf")
+    Some(NamedFile::open("/tmp/foo.pdf").await.expect("failed to open foo.pdf"))
 }
\ No newline at end of file