From deacc6024b03d6d9d2d1b730b5c38f791988fd5c Mon Sep 17 00:00:00 2001
From: Ondrej Vlach <ondrej@vlach.xyz>
Date: Thu, 18 Jan 2024 13:50:08 +0100
Subject: [PATCH] fix(BankPaymentValidator): check for negative identification
 number

---
 src/Validator/BankPaymentIdentificationNumberValidator.php      | 2 +-
 .../Validator/BankPaymentIdentificationNumberValidatorTest.php  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/Validator/BankPaymentIdentificationNumberValidator.php b/src/Validator/BankPaymentIdentificationNumberValidator.php
index 3459da2..122b065 100644
--- a/src/Validator/BankPaymentIdentificationNumberValidator.php
+++ b/src/Validator/BankPaymentIdentificationNumberValidator.php
@@ -24,7 +24,7 @@ class BankPaymentIdentificationNumberValidator extends ConstraintValidator
             throw new UnexpectedValueException($value, "string");
         }
 
-        if (strlen($value) <= 10 && filter_var($value, FILTER_VALIDATE_INT) !== false) {
+        if (strlen($value) <= 10 && filter_var($value, FILTER_VALIDATE_INT) !== false && (int) $value > 0) {
             return ;
         }
 
diff --git a/tests/Validator/BankPaymentIdentificationNumberValidatorTest.php b/tests/Validator/BankPaymentIdentificationNumberValidatorTest.php
index d9e08e9..d33db73 100644
--- a/tests/Validator/BankPaymentIdentificationNumberValidatorTest.php
+++ b/tests/Validator/BankPaymentIdentificationNumberValidatorTest.php
@@ -35,6 +35,6 @@ class BankPaymentIdentificationNumberValidatorTest extends ValidatorTestCase
     }
 
     private function failureDp(): array {
-        return [['122.b'], ['a.a'], ['a'], ['2.040'], ['2,a'], ['122.1'], ['12345678901']];
+        return [['122.b'], ['a.a'], ['a'], ['2.040'], ['2,a'], ['122.1'], ['12345678901'], ['-323']];
     }
 }